Repository navigation
fix(page): leave the window size to Chrome when window_size is nil - #339
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #278.
window_size: nilmade Cuprite raiseFerrum::BrowserError: Invalid parameterson every page. Ferrum already leaves out--window-sizewhen the size isnil, butPage#prepare_pagealways calledresize(width: nil, height: nil), and Chrome rejectsBrowser.setWindowBoundswithout a size.Now Cuprite resizes only when a size is set. Otherwise it applies just the viewport settings, so
mobile:andscale_factor:still work. Chrome keeps its own window size, which makesstart-maximizedusable:Verified in headful Chrome on a 2560×1440 screen: with
start-maximizedalone the window stays 1024×768 (normal), while withwindow_size: nilit opens at 2560×1410 (maximized).