Repository navigation
Make harness-ractor work on Windows - #550
Merged
Merged
Conversation
Etc::SC_PAGESIZE is not defined on Windows, so every harness-ractor benchmark failed with a NameError at load time. The page size is used only to read /proc/self/statm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two Ractors appending to the same file lose lines on Windows, where Ruby emulates O_APPEND by looking up the end of the file before each write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #538,
harness-ractor/harness.rbcallsEtc.sysconf(Etc::SC_PAGESIZE)at load time.Etc::SC_PAGESIZEis not defined on Windows, so every benchmark that usesharness-ractorfails there with aNameErrorbefore it starts. The page size is only needed to read/proc/self/statm, so I look it up only when that file exists.With that fixed,
test/ractor_harness_test.rbstill fails on Windows, because two Ractors append to the same file and some lines get lost. Each Ractor now writes to its own file. Nothing changes on Linux.Generated with Claude Code