Skip to content

Remove uses of the deprecated Add Morphism and Add Relation commands. - #325

Open
ppedrot wants to merge 1 commit into
rocq-prover:masterfrom
ppedrot:deprecate-add-morphism
Open

ppedrot wants to merge 1 commit into
rocq-prover:masterfrom
ppedrot:deprecate-add-morphism

Conversation

@ppedrot

@ppedrot ppedrot commented Nov 14, 2026

Copy link
Copy Markdown
Member

They were deprecated in rocq-prover/rocq#22705. We now declare the corresponding Proper, Equivalence and PreOrder instances directly.

@proux01
proux01 force-pushed the deprecate-add-morphism branch from 9d6a105 to 183de0e Compare November 17, 2026 15:46
@proux01

proux01 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Rebased in hope to get a greener CI

@ppedrot

ppedrot commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

@proux01 doesn't seem to be very effective. Should we merge this already?

@proux01
proux01 force-pushed the deprecate-add-morphism branch from 183de0e to da95a80 Compare November 19, 2026 07:59
@proux01

proux01 commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Looks like everybody conspired recently to break the CI by silently switching to dune ;)
Should be better now (still have to fix metarocq-test) and we should know what's actually broken (at least coqprime apparently)

@proux01

proux01 commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

@ppedrot you can ignore the metarocq-test failure, other failures (coqprime, category-theory, fiat-parsers) look real

They were deprecated in rocq-prover/rocq#22705. We now declare the
corresponding instances directly, together with the constants that the
commands used to generate, so that all the previous names remain available.
@ppedrot
ppedrot force-pushed the deprecate-add-morphism branch from da95a80 to 06a1a8f Compare November 19, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants