Repository navigation
fix(window): finish first load while minimized - #58
Merged
Merged
Conversation
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem: if you minimize the window while the page is still loading the first time, chromium throttles the hidden page, so it doesn't paint. on restore you get a flat color for a moment before the page shows up. one user on kde wayland also saw the first song not start.
fix: background throttling is off for the main window until the first media playback (
media-started-playing) or 60s, whichever comes first, then it goes back on. it's set up per window increateMainWindow, so a window recreated on macos activate gets it too. the logic is a small helper with tests (play, timer, close, destroyed window, once only). no plugin or ipc needed for the trigger.numbers (podman, xvfb + openbox, software rendering, minimized right after launch, one core = 100%):
not tested on real wayland or macos. i could not reproduce the "song doesn't start" part, only the missing paint.
used claude code to write this, tested locally in podman