Repository navigation
fix: hide proxy credentials in logs - #57
Merged
Merged
Conversation
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the proxy url got logged as is on startup (
Using proxy: ...), so a proxy likehttp://user:pass@host:portput the password in the logs. auth proxy adapter did the same with the upstream proxy, and its connection error logged the whole socks error, which keeps the proxy password inoptions.added a small
redactProxyUrlhelper that turnshttp://user:pass@host:portintohttp://***@host:port. it's plain string work so it never throws, works without a scheme, with socks5, and with passwords that have@or:in them. the value passed to chromium is unchanged. the socks connection error now only logs the message.added tests/redact-proxy.test.ts.
used claude code to write this, tested locally in podman