Skip to content

fix: hide proxy credentials in logs - #57

Merged
bercedev merged 2 commits into
masterfrom
fix/mask-proxy-log
Nov 20, 2026
Merged

bercedev merged 2 commits into
masterfrom
fix/mask-proxy-log

Conversation

@bercedev

Copy link
Copy Markdown
Member

the proxy url got logged as is on startup (Using proxy: ...), so a proxy like http://user:pass@host:port put the password in the logs. auth proxy adapter did the same with the upstream proxy, and its connection error logged the whole socks error, which keeps the proxy password in options.

added a small redactProxyUrl helper that turns http://user:pass@host:port into http://***@host:port. it's plain string work so it never throws, works without a scheme, with socks5, and with passwords that have @ or : in them. the value passed to chromium is unchanged. the socks connection error now only logs the message.

added tests/redact-proxy.test.ts.

used claude code to write this, tested locally in podman

@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

@bercedev
bercedev merged commit c944231 into master Nov 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant