Repository navigation
Skill restructure: Python-first flow-curve-analysis - #47
Open
marcocaggioni wants to merge 1 commit into
Open
marcocaggioni wants to merge 1 commit into
marcocaggioni wants to merge 1 commit into
Conversation
…-object contracts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill restructure: Python-first flow-curve-analysis
Restructures the
flow-curve-analysisskill so the agent executes via thePython API (holding result objects as values) instead of shelling out to the
CLI. Same workflow, same judgment content — new hands.
What changed
rheofit.print_steps/discover_steps/analyze/fit/plot.The CLI stays as the quotable plan artifact (every proposed plan still shows
the equivalent command) and the one-shot terminal route — now a compact
CLI reference instead of the main text.
analysis.py/models/_fitcore.py: the exactfit()dict keys(
success,params,redchi,cond,notes,x/y_data/y_fit,parent/parent_redchi), theAnalysisdataclass fields (results,summarycolumns,outputs,equation,output_dir), anddf.attrs— plus composition patterns (head-to-head model comparison, seed
robustness, cross-model summary tables) that only work with values.
ladder-ordered candidates, the agent climbs programmatically —
redchi > 0.1+ visible residual structure + all params identified →next rung; never switches families; nesting violations get one
thorough/seed+1retry. No more "offer to climb" round-trips.uv sync/pip install -e ./two-line
sys.pathfallback). The four CLI fallback routes and the PEP 723last-resort are gone from the docs;
scripts/flow_curve_fit.pystays ondisk, unreferenced.
a.summary/res["notes"]directly;Office-workflow tip notes the native-table transcription is direct from values.
Untouched
Fitting Contract, Visualization Contract, model tables (Branch A/B), fixed
Carreau exponents, interview-first golden rule, demo walkthrough (both mermaid
diagrams), material-behaviour reporting guidance, Library Layout, Data Loading
Notes, contributor guides, When to Use, environment packages. Both mirror
copies (
.github/skills/andrheofit/skills/) updated identically.Checks
rheofit/analysis.py,rheofit/models/_fitcore.py,rheofit/report.py(exact keys/columns)ast.parseclean (3 remaining "failures"are the pre-existing intentional sketches, unchanged)
Left unmerged for review.