Repository navigation
feat(start): editable phone Start page widgets - #107
Merged
Merged
Conversation
Each card on the phone Start page is now its own component under components/start/widgets, listed in a registry (START_WIDGETS). The page renders from a stored list of widget ids (useStartLayout), so widgets can be shown, hidden and reordered; the kiosk Dial is unchanged. - Settings > General > Display & Appearance > Widgets lists the widgets on the page and the ones available, with drag-and-drop reordering by a grip (pointer events, arrow keys on the grip) and a Reset to default. - Each widget has its own page with a Show switch and Move up/down. - The Menu drawer's Widgets row opens the Widgets page. - Display & Appearance is regrouped: Appearance (Widgets, Pages, Navigation) before Display; Group gains a nested heading level. - The stored layout joins the settings context preferences; leaving Settings clears the stale ?widget= param.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useStartLayout, so they can be shown, hidden and reordered.Test plan
vp checkandvp testpass?page=settings&view=widget&widget=mapwith touch simulation on and confirm the controls respond