Repository navigation
feat: add a status bar with segments and notices - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: there was no place for an application to show state such as the selected item, counts, or the result of an action.
After:
StatusBardraws one row with a label for the focused view, segments that any component publishes withuseStatusSegment(left or right, with a tone), and notices fromuseNotifythat briefly replace the left side ("Refreshed 5 hosts").StatusStorelets code outside React publish status too. The demo shows the selected host's health and a host count, andrshows a refresh notice.This also adds
hint: falseto bindings, which keeps a binding in help but out of the one-line hints so the hints fit in 80 columns.How: the store keeps segments in order and mount order, skips updates that change nothing, and owns one notice timer that a newer notice replaces. Guide in
docs/status-bar.md, with tests.Stacked on the panes PR; merge that first.