Repository navigation
feat: add split panes with focus and pane-scoped keys - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: an application drew its own boxes and had no notion of which region was active.
After:
SplitandPanedivide the screen into nested regions sized in cells (28), percentages ('30%'), or shares ('2fr').PaneFocusProviderbindsTabandShift+Tabto move focus, the focused pane's border and title light up, andusePaneKeybindingsregisters keys that only the focused pane receives. The demo now shows a host list, a detail pane, and an events pane.How: sizes map onto Yoga flex styles along the parent split's axis.
PaneFocuskeeps panes inorderthen mount order, honours aninitialFocusthat mounts late, and moves focus to a neighbour when the focused pane unmounts. Guide indocs/panes.md, with tests.Stacked on the keybindings PR; merge that first.