Skip to content

docs(management-sdk): correct Node getFlag examples - #771

Merged
roncohen merged 1 commit into
mainfrom
docs/fix-management-node-examples
Oct 14, 2026
Merged

roncohen merged 1 commit into
mainfrom
docs/fix-management-node-examples

Conversation

@roncohen

Copy link
Copy Markdown
Contributor

Summary

Correct both Node SDK evaluation examples in packages/management-sdk/README.md to call client.getFlag(context, key) rather than reversing the arguments.

Documentation only; no SDK implementation or version changes. Split out of #770 to keep the flag event PR focused.

Validation

  • Checked the argument order against packages/node-sdk/src/client.ts.
  • README formatting and git diff --check passed.

@roncohen
roncohen marked this pull request as ready for review October 14, 2026 21:07
Copilot AI balanced review requested due to automatic review settings October 14, 2026 21:07
@roncohen
roncohen enabled auto-merge October 14, 2026 21:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@roncohen
roncohen added this pull request to the merge queue Oct 14, 2026
Merged via the queue into main with commit 55b364e Oct 14, 2026
7 of 8 checks passed
@roncohen
roncohen deleted the docs/fix-management-node-examples branch October 14, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants