Repository navigation
Remove the synthesized piano; lessons and examples use grandpiano (0.11.0) - #38
Merged
Merged
Conversation
…11.0) The user does not like the synthesized piano's sound. It leaves the instrument set: a score or a custom instrument's `base` that still says "piano" fails with "piano" was removed in 0.11.0; use "grandpiano" instead. (REMOVED_INSTRUMENTS in src/instruments/index.ts; also getInstrument and `jinglescript instruments piano`). A score may still define an instrument of its own called "piano". The synth itself moves to tests/piano-synth.ts, where it only makes the stand-ins for the grand piano's recordings (tests/sample-fixture.ts), so every grandpiano golden hash still holds offline. - Seven examples move to grandpiano (new golden hashes); a-piano.json is gone (a-grandpiano.json shows the piano). None of the non-lesson ones gives a len, so their notes ring as before. - The guide: grandpiano is the piano; its custom layering and sheet-music examples use it. - Sheet music: a grandpiano part with no name is printed "Piano". - Tests that used the piano as a ringing code instrument use grandpiano with the stand-ins, or a vibraphone or marimba where the instrument does not matter. - 0.11.0 for both packages (a breaking change); the plugin needs jinglescript ^0.11.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… stays offline Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synthesized
pianois removed, and lessons and examples now usegrandpiano, the recorded Steinway. This is a breaking change, so both packages go to 0.11.0.What changes for a score
baseis"piano"now failscheckScorewith:"piano" was removed in 0.11.0; use "grandpiano" instead.getInstrumentandjinglescript instruments pianosay the same."piano".Where the synth went
tests/piano-synth.ts. Its only use is to make the stand-ins for the grand piano's recordings (tests/sample-fixture.ts).grandpianogolden hash still holds.Examples, guide, tests
grandpiano, with new golden hashes: three lessons (C major scale, Twinkle, Happy Birthday),layered-hit,lyrics-hatena,piano-ukulele-clapsandriser-reveal.a-piano.jsonis deleted, sincea-grandpiano.jsonalready shows the piano.len, so their notes still ring out as before. The lessons givelen, so the dampers now end each note there.grandpianois the piano, and its custom-layer and sheet-music examples use it.grandpianowith the stand-ins. Tests where the instrument doesn't matter use a vibraphone or marimba.Measured, with the real recordings
riser-revealis held below the loudness target by the peak ceiling. That was already the case with the old piano.Verification
smoke.sh: passout/grandpiano/, with the old piano inout/old-piano/)🤖 Generated with Claude Code
work in jinglescript