Resolve setup-env from the Metro project root - #58258
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
@react-native/metro-configcurrently resolvesreact-native/setup-envrelative to its own package location. In strict or multi-version installs, that can select a different React Native copy—or fail—even though the configuredprojectRootcontains the correct export.Resolve the bootstrap module with
require.resolve(..., {paths: [projectRoot]}), matchingcommunity-cli-plugin's existing project-scoped behavior. This does not change normal single-version layouts; it makes the existingprojectRootcontract deterministic across package-manager layouts.Changelog:
[GENERAL] [FIXED] - Resolve the React Native setup module from the configured Metro project root.
Test Plan:
metro-configand verified the generated configuration resolves the samereact-native/setup-envasrequire.resolve(..., {paths: [projectRoot]})for a separate React Native project.<projectRoot>/node_modules/react-native/setup-env.js.yarn build metro-configgit diff --checkmetro-configcurrently has no Jest tests. Its source wrapper loadsindex.flow.js, which the root Jest Node transform leaves as ESM, so a direct package test fails before execution; this change therefore uses built-output resolution verification rather than adding a bespoke compile/eval-only harness for the one-line fix.