Complete deep import warning coverage - #58250
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The development-only deep-import warning plugin covers static imports, CommonJS requires, and named re-exports, but has three inconsistent boundaries:
export * from "react-native/deep"bypasses the warning even though a named re-export warns.import("react-native/deep")bypasses the same package-boundary diagnostic.requireis mistaken for the free CommonJS loader and produces a false warning.Share one recorder across both export declaration forms, recognize Babel literal dynamic-import callees, and require
requireto be unbound before treating it as CommonJS. A combined scope regression proves dynamic import still warns inside a function where the sibling localrequireis shadowed.Changelog:
[GENERAL] [FIXED] - Complete and scope React Native deep-import development warnings.
Test Plan:
git diff --checkpass.This only corrects development diagnostics; runtime and release output are unchanged. No UI change.