Repository navigation
fix(nautobotop): revert k8s.io/utils bump that broke the container build - #2573
Merged
Merged
Conversation
This reverts commit 6c3ebd7. The new k8s.io/utils requires Go 1.26, so go mod tidy raised the go directive in go/nautobotop/go.mod. The nautobotop Dockerfile builds on golang:1.25, so `go mod download` fails with 'go.mod requires go >= 1.26' and the container build is broken on main.
A Go module update can raise the go directive in go.mod to match a dependency, which breaks container builds pinned to an older golang image. Require a human to merge gomod updates until the container builds are enforced as required checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Reverts #2572: the new
k8s.io/utilsraised thegodirective ingo/nautobotop/go.modto 1.26, but the Dockerfile builds ongolang:1.25, so the container build fails onmain.Also stops Renovate from automerging
gomodupdates.The build did fail on #2572, but
mainhas no required status checks and Renovate bypasses the PR rules, so it merged anyway. Follow-up (repo settings): require checks onmainor drop Renovate's bypass.Upgrade impact