fix(ci): exempt the real bot login from the DCO check - #6
Merged
Merged
Conversation
The project bot signs in as quality-runtime[bot]; qualityruntime[bot] does not exist, so the exemption never matched and a pull request the bot opened without a sign-off would fail the dco job. Signed-off-by: quality-runtime[bot] <330432719+quality-runtime[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dcojob exempts pull requests opened by the project's GitHub App, but it compared againstqualityruntime[bot]— an account that does not exist. The app signs in asquality-runtime[bot](id 330432719), so the exemption never matched, and a bot-opened pull request without a sign-off would fail. This corrects the login in the workflow condition and inAGENTS.mdandCONTRIBUTING.md, which state the rule.The check stays keyed on who opened the pull request, not on commit authors: GitHub usernames cannot contain brackets, so only an app can hold a
[bot]login.Verified:
gh api 'users/quality-runtime[bot]'resolves andusers/qualityruntime[bot]is a 404;bun run checkandreuse lintpass. The condition itself only runs on a pull request.