Repository navigation
Keynote UI + full-English line: content, CLI, and comments - #3
Merged
Merged
Conversation
The typer docstrings are the --help surface; they were the last user-visible Chinese in the CLI. Echo output was already English.
199 controls (CSF 106 + ISO 93) carried Chinese interpretation bodies. They are translated via the drafter vendor's chat API and now ship as state=draft / basis=inferred / locale=en: no human has signed the English text, so the pack must not pretend otherwise. The signed Chinese originals live on the zh line. 800-53 stays publisher-signed English. Guard test: no CJK may remain in any shipped field.
The translated CSF/ISO rows are labelled locale=en while the signature digest covers locale, so the signed 800-53 rows keep their zh-CN label. Querying one locale strictly therefore hid one tier or the other. Ask for the preferred locale first, then fall back to whatever language the control actually has. Also track the keynote redesign in web tests: the theme tokens moved to #0d0f12/#f8f9fa and the omnibox quick chip carries a control id outside the daily block.
…src/ The last Chinese outside data files: ~1900 comment/docstring lines across web/, cli/, query/, interpret/, llm/, pack/, blindtest/, assess/, schema/, publish/, ingest/, userframework/, identity/ and root modules — including the CSS/JS comments inside the keynote template that ship in every page. Functional data stays and is deliberate: the Chinese-document parsing tables (spreadsheet column headers 编号/标题, CJK radical repair, chapter regexes), the Chinese citation-detection regexes in lint, the colloquial-formal register pairs in proofread, and the advocacy markers in blindtest/tally — now bilingual, since a judge's note may be written in either language (restores the blind-test pass-line behaviour).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (five commits, oldest first)
state=draft / basis=inferred / locale=en. 800-53 stays publisher-signed.QueryAPI.interpretation()filtered hard onlocale=zh-CN, which hid one signing tier or the other; now prefers the requested locale and falls back to the language the control actually has.Functional Chinese data is deliberately kept: spreadsheet column headers (编号/标题…) for importing Chinese policies, CJK radical repair, chapter regexes, citation-detection patterns, register pairs, and the blind-test advocacy markers — now bilingual after the sweep initially broke the Chinese half of the pass-line match.
Verification