Skip to content

Fix /icon.png import after the package move #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pythonjeff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix /icon.png import after the package move #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion palmer/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ async def artifact_page(token: str):
async def icon_png():
"""The page's favicon and apple-touch-icon. No token: it is the same mark
for everyone and carries no one's data."""
from cards import render_icon
from palmer.cards import render_icon
return Response(content=render_icon(), media_type="image/png",
headers={"Cache-Control": "public, max-age=86400"})

Expand Down
8 changes: 8 additions & 0 deletions tests/test_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,3 +1037,11 @@ def test_the_description_leads_with_the_weather_when_named(self):

def test_the_icon_is_a_png(self):
assert cards.render_icon()[:8] == b"\x89PNG\r\n\x1a\n"

def test_the_icon_route_serves_it(self):
"""The route imported `cards` by its pre-package name and 500'd in
production while every unit test of render_icon passed."""
from fastapi.testclient import TestClient
from palmer.main import app
r = TestClient(app).get("/icon.png")
assert r.status_code == 200 and r.headers["content-type"] == "image/png"
Loading