gh-156680: Raise the documented error from IPv6Network.next_network() - #156681
Open
fedonman wants to merge 1 commit into
Open
gh-156680: Raise the documented error from IPv6Network.next_network()#156681fedonman wants to merge 1 commit into
fedonman wants to merge 1 commit into
Conversation
…work() next_network() guarded address-space exhaustion with except OverflowError, which only int.to_bytes() on the IPv4 path raises. _BaseV6._string_from_ip_int() raises ValueError instead, so the handler never ran for IPv6 and the internal 'IPv6 address is too large' message escaped. Range-check next_ip against _ALL_ONES before formatting it, which decides the outcome for both address families before either path runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Range-check
next_ipagainst_ALL_ONESinnext_network()instead of catchingOverflowError, which only the IPv4 path raises. The IPv6 path went through_BaseV6._string_from_ip_int(), whoseValueErrorescaped uncaught.next_network()is new in 3.16 and unreleased, so this is folded into the entry the method landed with and needs no NEWS fragment.IPv6Network.next_network()raises the wrong error when addresses run out #156680