Fix non-ASCII headers in the legacy HTTP parser - #1758
Open
thorvald-oai wants to merge 1 commit into
Open
Conversation
thorvald-oai
marked this pull request as ready for review
September 10, 2026 20:20
Member
|
I didn't change the behavior of the legacy parser on purpose because it's only used by people who don't maintain their software at this point and I didn't want to break it for them. |
Member
|
Sorry I misunderstood what you were proposing. I thought you were proposing to change the encoding, while you're actually only avoiding the double validation. |
Member
|
For my understanding, what is it that led you to propose this change? Just trying to maintain some understanding of how websockets is used and what problems occur :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve non-ASCII header values in the legacy HTTP parser by avoiding a second validation after surrogate decoding. Raw header validation remains in place.
Includes a regression test for a UTF-8 header value. This applies the modern parser's existing fix to the legacy parser.