Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated contributions of the same
@singletonclass currently create separate objects within multibound lists and dictionaries. Respect the class decorator by sharing a class-specific cache key within each collection, and apply the scope to dictionary values before wrapping them with their keys.Explicit binding scopes keep their existing per-contribution behavior, including
scope=singletonandscope=noscope. Ordinary bindings, other provider kinds, and custom scopes retain their existing behavior.Fixes #298. The regression test comes from @davidparsson's open draft #292, which currently contains the test without a production fix. This change does not implement the parent/child collection extension proposed in #324.
Validation on CPython 3.12.14 / macOS arm64:
check-manifest --no-build-isolationpassed, using the repository's declared tool versions.The other Python/PyPy and Linux CI environments have not been run locally.