Repository navigation
Conversation
main() opens the output with "wb" before it reads the input, which truncates the input when both are the same file. With -f -o data data the command replaced data with an empty gzip file and exited with status 0.
rhpvorderman
approved these changes
Nov 6, 2026
rhpvorderman
left a comment
rhpvorderman
left a comment
Collaborator
There was a problem hiding this comment.
Yes, excellent. This will prevent some whoopsiedoodles.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python -m isal.igzip -f -o data datareplacesdatawith an empty gzip file and exits with status 0. The input is also lost with-d, after answeringyat the overwrite prompt, and when the output path names the input another way, such as./dataor adata.gzsymlink todata.main()insrc/isal/igzip.pyopens the output with"wb", which truncates the input before it is read. The command now exits with an error before the overwrite prompt whenos.path.samefile()reports that the input and output are the same file. The newtest_infile_out_file_same_filetest fails on develop.Checklist