Repository navigation
Make IsalError exceptions picklable - #321
Merged
Merged
Conversation
The class was created as "igzip_lib.IsalError", so pickle looked for it in a module named igzip_lib, which does not exist. An error raised in a worker process could not be sent to the parent process.
Collaborator
|
Great find. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
isal_zlib.errorraised in amultiprocessingorconcurrent.futuresworker process does not reach the parent process, because pickling it raisesPicklingError. For example,cutadapt -j 2on a gzip file with invalid deflate data waits forever without an error message.src/isal/igzip_libmodule.ccreates the class asigzip_lib.IsalError, and no module namedigzip_libexists. This PR usesisal.igzip_lib.IsalError, the name tracebacks now show, and addstest_failure_pickletotests/test_igzip_lib.py, which fails on develop. PR #318 still uses the old name.Checklist