You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Close configuration gaps left by the rumdl migration #1368
Follow-ups to the rumdl migration (#1352, PR #1360), found in a review of 2a60ecc.
They are small configuration gaps; none changes what the current files report.
1. .agents/skills is not linted by just docs lint or CI
.rumdl.toml's include lists docs/**/*.md, benchmarks/*.md, scripts/**/*.md, cloudformation/**/*.md and /*.md, so just docs lint (rumdl check) and the Docs Lint workflow skip the four SKILL.md files under .agents/skills/. .agents/skills/development-workflow/SKILL.md tells agents to run mise exec -- rumdl check .agents/skills separately, which nothing enforces; the files pass it today.
The workflow's **.md path filter already triggers on them, so adding .agents/skills/**/*.md to include (and the list in CLAUDE.md's Markdown Lint section) would make CI check them, and the separate command in the skill could go.
2. The .jsonc license header entry has no files left
scripts/check_license_headers.py keeps a .jsonc entry in SUFFIX_BLOCKS, with a test row in scripts/tests/test_check_license_headers.py.
Its only file, .markdownlint-cli2.jsonc, was removed by 07f826c; no tracked .jsonc file remains (every other suffix in the table has files).
Remove the entry and its test row, unless keeping it for a future JSONC file is intended.
3. MD043 and MD044 are enabled without configuration
enable lists MD043 (required heading structure) and MD044 (proper names), but .rumdl.toml sets neither headings nor names, whose defaults are empty (rumdl config --defaults), so both rules never report anything.
They were equally inert under markdownlint 0.38, which the enable list mirrors.
Either configure them (e.g. MD044 names for PyAthena, Athena, SQLAlchemy, fsspec, with code-blocks = false) or drop them from enable with a note next to the other disabled rules.
Activity
Merge pull request #1371 from pyathena-dev/docs/1368-rumdl-gaps