Skip to content

CS2 changelog: player_status.is_spotted removed (2026-10-21) - #76

Merged
billfreeman44 merged 4 commits into
masterfrom
remove-is-spotted-changelog
Oct 21, 2026
Merged

billfreeman44 merged 4 commits into
masterfrom
remove-is-spotted-changelog

Conversation

@billfreeman44

@billfreeman44 billfreeman44 commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

The CS2 changelog's entry for the removal of player_status.is_spotted, rendered from igl-gotv-v2's scripts/csds-changelog/changes.yaml.

  • changelog.md and changelog-by-channel.md gain one columns-removed entry under 2026-10-21, the day the converter release ships (the maintainer set it for that day).
  • npm run build passes.

Goes with docs#75 (spec and data dictionary). Both sit behind the docs production lock in igl-plant#119, which waits for csgo-ppp#221 in production. Related: csgo-coach#267, csgo-rushb#136.

🤖 Generated with Claude Code

Rendered from igl-gotv-v2 scripts/csds-changelog/changes.yaml. The date and the release line are corrected when the converter change reaches production.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Regenerate the changelog pages from the canonical source and preserve provisional date markers.

2 open issues
What changed in this PR

Documents the provisional removal of player_status.is_spotted from the CS2 CSDS changelog.

Changes:

  • Adds date-based and channel-specific changelog entries.
  • Records the update in CHANGELOG.md.
File Description
docs/​datascience/​adx/​cs2/​csds/​changelog.md Adds the provisional removal entry.
docs/​datascience/​adx/​cs2/​csds/​changelog-by-channel.md Adds the channel-specific removal entry.
CHANGELOG.md Records the documentation update.

Review effort: Lite


## player_status

- **2026-10-21**, column removed: `is_spotted`. **Breaking:** no longer written, so code that reads it breaks. It was the game's own "spotted" flag on each player, and it proved unreliable as a sign of who could see whom: checked against real kills, it was never set for one victim who was being shot, and set only a fraction of a second before another kill. Matches published earlier keep the column. Some later manifests still list it, with origin `replay-deleted` and no data behind it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken. The entry is now marked approx: true in the source, so both views say About 2026-10-21 (by-channel: - **About 2026-10-21**, column removed). The PR stays a draft until the converter release reaches production; then the real date replaces it and the marker goes.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: the maintainer set the converter release for 2026-10-21, so the date is final and the approximate marker is gone from both views. The PR is now ready for review.

Comment on lines +28 to +34
## 2026-10-21

_The converter release that stops writing player_status.is_spotted (date provisional)._

**Columns removed**

- `player_status.is_spotted`: **Breaking:** no longer written, so code that reads it breaks. It was the game's own "spotted" flag on each player, and it proved unreliable as a sign of who could see whom: checked against real kills, it was never set for one victim who was being shot, and set only a fraction of a second before another kill. Matches published earlier keep the column. Some later manifests still list it, with origin `replay-deleted` and no data behind it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already the case. The entry was added to the canonical source first, igl-gotv-v2's scripts/csds-changelog/changes.yaml (pushed to its main), and both pages were regenerated with render.py, not edited by hand. That repo isn't visible from this PR, which is why it looked like a page-only edit. The fix for the other point went the same way: source, then re-render.

billfreeman44 and others added 2 commits October 21, 2026 07:36
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@billfreeman44 billfreeman44 changed the title CS2 changelog: player_status.is_spotted removed (provisional date) CS2 changelog: player_status.is_spotted removed (2026-10-21) Oct 21, 2026
@billfreeman44
billfreeman44 marked this pull request as ready for review October 21, 2026 12:40
@billfreeman44

Copy link
Copy Markdown
Member Author

Merged master (#75) into the branch. The only conflict was CHANGELOG.md, where both PRs added a line at the top of ### Changed under ## Unreleased; both lines are kept. The diff against master is now this PR's own three files. npm run build passes.

@billfreeman44
billfreeman44 merged commit b250387 into master Oct 21, 2026
5 checks passed
@billfreeman44
billfreeman44 deleted the remove-is-spotted-changelog branch October 21, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants