Repository navigation
[HOTFIX] Use github-pr-review reporter for Verible lint on PRs - #100
Merged
Merged
Conversation
On pull_request events, reviewdog's github-check reporter fails with a 404 when updating the check run it creates, failing lint-sv even when Verible reports nothing. Post findings as PR review comments instead; keep github-check for push events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lint-svfails onpull_requestruns even when Verible reports no findings (e.g. on #99, and earlier in runs 42860072721 and 42986548737):The failure is in reviewdog's
github-checkreporter, which creates a separateverible-verilog-lintcheck run and then cannot update it. Push runs on the same commits pass.This switches the reporter to
github-pr-reviewforpull_requestevents, so findings are posted as PR review comments, and keepsgithub-checkfor pushes. Pass/fail is still governed byfail_on_error.