Skip to content

[HOTFIX] Use github-pr-review reporter for Verible lint on PRs - #100

Merged
FrancescoConti merged 1 commit into
develfrom
fc/fix-ci-lint
Nov 20, 2026
Merged

FrancescoConti merged 1 commit into
develfrom
fc/fix-ci-lint

Conversation

@FrancescoConti

Copy link
Copy Markdown
Member

lint-sv fails on pull_request runs even when Verible reports no findings (e.g. on #99, and earlier in runs 42860072721 and 42986548737):

reviewdog: failed to post result: PATCH .../check-runs/<id>: 404 Not Found

The failure is in reviewdog's github-check reporter, which creates a separate verible-verilog-lint check run and then cannot update it. Push runs on the same commits pass.

This switches the reporter to github-pr-review for pull_request events, so findings are posted as PR review comments, and keeps github-check for pushes. Pass/fail is still governed by fail_on_error.

On pull_request events, reviewdog's github-check reporter fails with a
404 when updating the check run it creates, failing lint-sv even when
Verible reports nothing. Post findings as PR review comments instead;
keep github-check for push events.
@FrancescoConti FrancescoConti changed the title [ci] Use github-pr-review reporter for Verible lint on PRs [HOTFIX] Use github-pr-review reporter for Verible lint on PRs Nov 19, 2026
@FrancescoConti
FrancescoConti merged commit 896f44c into devel Nov 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant