Repository navigation
Propagate simulator failures from make run - #42
Open
BerkmKuzu1 wants to merge 1 commit into
Open
BerkmKuzu1 wants to merge 1 commit into
BerkmKuzu1 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batch
runrecipe can report success whenvsimfails. Its commands are separated by semicolons, so the finalif grep ...returns 0 when the transcript lackserrors happened, masking the simulator's exit status. Both CI and the regression runner use this target.Chain
cd,vsim, and the existing transcript check with&&. A failed directory change or simulator invocation now makes the target fail; successful runs still reach the transcript check.Reproduction with Questa on PATH, from the repository root:
Questa 10.7c rejects the option with exit status 1. Before this change,
makereturns 0; afterward it returns 2 and reportsError 1.Validation with GNU Make 4.3 / Bash on WSL and native Questa 10.7c:
errors happenedstill fails.$finish(0)smoke test confirmed a successful Questa exit.These checks cover command/error handling. The full Neureka RTL regression was not run.