Repository navigation
Sample resolved I2C inputs while the VIP drives the bus - #310
Open
lionelZhaowy wants to merge 5 commits into
Open
lionelZhaowy wants to merge 5 commits into
lionelZhaowy wants to merge 5 commits into
Conversation
AI assistance: OpenAI Codex assisted implementation and validation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The I2C input buffers in
vip_cheshire_soc_tristateare enabled only when the DUT releases the line. When the DUT drives SDA or SCL low, its input becomes high impedance instead of reflecting the resolved bus value.This patch connects both I2C inputs directly to the resolved wires. Output buffers, pullups and SPI buffers stay unchanged.
The same 78-check test reports 16 input mismatches before the fix and zero after. It tests the simulation wrapper, with no synthesizable RTL changes.
Validation, reproduction and scope
Validation used official main
6c6dd5e834347f72c7be31cd6c41021ec293c5b9. The same finite 78-check test ran against both versions with VCS W-2024.09-SP1. It instantiated the complete real tristate module, extracted without edits. A package shim supplied only the SPI chip-select port width.zinstead of0, followed by the expected failure.Run
make sim-test-i2c-inputswith VCS on PATH. The target checks the summary, errors, and normal finish.The full checkout passes the license and C/C++ format checks, and
hw-all,sw-all, andsim-allbuild with the CI GCC 12.2.0 toolchain. The license job uses Ubuntu 24.04 so that its existing Python 3.9 action can start.Full SoC EEPROM boot still reports an SCL timing violation: a 385 ns low pulse against the model minimum of 500 ns. The unmodified official base reports the same violation with the same image. Full EEPROM boot is not a passing result.
The public test and commands are in
target/sim/test/. No EEPROM model is needed. This verifies the simulation wrapper only. It does not claim full controller, EEPROM, or SoC verification. No synthesizable RTL changes.OpenAI Codex assisted with the patch, test, and validation. A separate AI review checked the source and logs.