Repository navigation
Conversation
floo_cut dropped all but one physical channel when NumPhysChannels > 1. Map virtual channel v to physical channel v like floo_router does and reject other combinations. floo_nw_cut cuts both directions of a narrow-wide link with three floo_cut instances and has a self-checking testbench (2 virtual and 2 physical wide channels, random backpressure).
Keep floo_cut for NumPhysChannels == NumVirtChannels, where every virtual channel is an independent spill register path, and add back the floo_vc_arbiter for one shared physical channel with VcNaive. Other configurations are rejected by an assertion that documents how to support them. Extend tb_floo_nw_cut to cover the wide link with no decoupling, a shared physical channel and separate physical channels.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
floo_nw_cutand fixfloo_cutfor multiple physical channelsWhat changed
floo_cutNumPhysChannels == NumVirtChannels: one spill register and data bus per virtual channel, fully parallel paths, no arbiter.floo_vc_arbiterpath for one shared physical channel,VcNaiveonly (newVcImplparameter, defaultVcNaive).Other
VcImplconfigurations have not been tested. For this reason, thefloo_vc_arbiteris used in its default configuration, as in the original version of this file.We are currently using this cut in the Gwaihir project, with two different data links in parallel. In the future, the module should be tested with the other
VcImploptions recently added to FlooNoC:credit basedandpreemptive valid.To track this task I opened Issue#250