Repository navigation
Track sent packets before immediate acknowledgements can arrive - #99
Open
DeveloperKubilay wants to merge 1 commit into
Open
DeveloperKubilay wants to merge 1 commit into
DeveloperKubilay wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A peer can acknowledge a datagram before
SocketManager.sendreturns, especially on loopback or with a custom socket transport. Recovery currently records the packet after that call, so the ACK can be processed before the packet is known and leave acknowledged bytes counted as in flight.Register recovery and idle-timer state immediately before sending, using the sender's clock. Successful-send statistics still advance after the send call.
Validation on current master (
101c733d):SenderImplTesttests pass with JDK 21 on Windows.No version, publishing or congestion-control changes are included.
Fork CI: the complete
./gradlew buildpassed on Linux / JDK 17 with the upstream workflow and no test exclusions: https://github.com/DeveloperKubilay/kwik/actions/runs/39651941641. Upstream PR checks remain separate.