Skip to content

🚨 Remove stale PSReviewUnusedParameter suppressions - #32

Merged
pspete merged 1 commit into
devfrom
pssa-stale-suppressions
Oct 5, 2026
Merged

pspete merged 1 commit into
devfrom
pssa-stale-suppressions

Conversation

@pspete

@pspete pspete commented Oct 5, 2026

Copy link
Copy Markdown
Owner

PSScriptAnalyzer 1.25.0 no longer reports PSReviewUnusedParameter for parameters used inside ForEach-Object blocks. The suppressions for NoEscape, ParametersToKeep, ParametersToRemove and DotSourceModule are now stale. When the rule fires elsewhere in the built psm1, a stale suppression raises an error, which fails the PSScriptAnalyzer tests under CI's Stop preference (PR #31).

Tested locally with PSSA 1.25.0: source (pwsh 7), built module (Windows PowerShell 5.1), and built module (Linux via WSL) all pass.

PSScriptAnalyzer 1.25.0 no longer flags parameters used inside ForEach-Object
blocks, so these suppressions now error under CI's Stop preference.
@pspete
pspete merged commit 47d89da into dev Oct 5, 2026
5 checks passed
@pspete
pspete deleted the pssa-stale-suppressions branch October 5, 2026 19:36
@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.53%. Comparing base (141114f) to head (3e308b2).
⚠️ Report is 4 commits behind head on dev.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #32   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         401      401           
  Lines        3696     3696           
=======================================
  Hits         3605     3605           
  Misses         91       91           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant