You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ABI vNEXT: generic vs specialized context functions #9
The current version of the ABI defines generic proxy_on_context_create() and proxy_on_context_finalize() functions which are used for VM and plugin lifecycle, as well as for per-stream lifecycle, which makes "context" a bit overloaded and confusing.
In case proxy_on_http_finalize() returns Action::Pause, the host would wait until proxy_resume() is called before calling proxy_on_http_finalize() again (which matches the behavior of other callbacks that have the ability to pause/resume processing).
+1 as a user. Using the same callback is really problematic when one plugin serves in different roles (which might be common to save on resources by reusing the VM/module).
I think this will need pausable access log extensions in envoy.
As discussed in the Proxy-Wasm meeting on 2/19, we're going to keep the generic interface with added context_type to avoid overloading "context" everywhere and to keep the ABI extensible with other context types in the future.
Related: #80 (Consistent style in the ABI (expanded vs minimal)).
Activity
htuch commentedon Aug 26, 2020
Seems a slam dunk interface improvement.
mattklein123 commentedon Aug 26, 2020
Huge +1 from me. I think this is one of the things that I initially commented on.
kyessenov commentedon Aug 26, 2020
+1 as a user. Using the same callback is really problematic when one plugin serves in different roles (which might be common to save on resources by reusing the VM/module).
I think this will need pausable access log extensions in envoy.
PiotrSikora commentedon May 21, 2026
As discussed in the Proxy-Wasm meeting on 2/19, we're going to keep the generic interface with added
context_typeto avoid overloading "context" everywhere and to keep the ABI extensible with other context types in the future.Related: #80 (Consistent style in the ABI (expanded vs minimal)).
cc @mpwarres @leonm1