Repository navigation
Fix installed-package smoke tarball discovery - #1
Merged
firegrass merged 1 commit intoOct 19, 2026
Merged
Conversation
Packet: BKLG-20261019-y295 Pack into a temporary directory and require a single .tgz so npm 10 prepare output cannot corrupt tarball discovery. Keep the installed CLI assertions and remove the entire prefix on success or failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm packcan write lifecycle output before its JSON, causing the installed-package smoke to fail while parsing the tarball filename. Pack into a dedicated temporary directory and require exactly one.tgzfile, so package discovery is independent of npm output. The existing installed CLI assertions remain in place, and the entire temporary prefix is removed on success or failure.Packet: BKLG-20261019-y295
Validation: the workflow recorded its local gate as passed for commit
030dfda8d1b13294c6bbf822c21eb25e5c1dbe2c(tree5d898f3b9e061e36d6f0b995ef18e485a2368b23): frozen-lockfile install,pnpm typecheck,pnpm test,pnpm build,node scripts/verify-package.mjs,pnpm pack:dry-run, andpnpm smoke:pack.