Repository navigation
Send only the file part on the Liskov upload path (v2.3.1) - #23
Merged
Merged
Conversation
PROOF's upload service accepts exactly one multipart `file` part and refuses any other field (liskov-ipfs-infra apps/upload-api/src/multipart.ts, fields: 0, LIA4010). v2.3.0's default path also sent pinataOptions/pinataMetadata, so every @v2 build without ipfs-endpoint failed at the pin step (canary run proof-computer/liskov-upload-canary 40512089049). The token already fixes CIDv0. The proxy path keeps the Pinata fields. The Liskov test now pins the form to ["file"]; it fails if the fields come back. Also records v2.3.0's upload change in the CHANGELOG. Refs BKLG-20261006-tae2, BKLG-20260625-jws4, ADR-0180 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186u36T3mfv2Jwy8ubvqtuJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the v2.3.0 default upload, which fails for every
@v2build withoutipfs-endpoint.PROOF's upload service accepts exactly one multipart
filepart and refuses any other field (liskov-ipfs-infraapps/upload-api/src/multipart.ts,fields: 0→LIA4010 "Upload request includes unexpected non-file fields.").ipfs-pinsentpinataOptionsandpinataMetadataon both paths. The canary run proof-computer/liskov-upload-canary 40512089049 got the intent issued, then failed at upload with exactly this error.file. The token already fixes CIDv0, matching the working Liskov-side uploader (liskov-rsipfs_upload.rs:371).ipfs-endpoint): unchanged, with the Pinata fields kept.["file"]and was mutation-checked: it fails when the fields are re-added.distrebuilt. Locally on the worktree:pnpm install --frozen-lockfile,typecheck,test(79/79),compileall,check:distall pass.v2.3.1and recordsv2.3.0's upload change.After merge: tag
v2.3.1(release.yml movesv2), then re-run the canary.Refs BKLG-20261006-tae2, BKLG-20260625-jws4, ADR-0180
🤖 Generated with Claude Code
https://claude.ai/code/session_0186u36T3mfv2Jwy8ubvqtuJ