Repository navigation
Ship the reusable workflow and its actions as v2 with LISKOV_ names - #15
Merged
firegrass merged 1 commit intoOct 2, 2026
Merged
Conversation
BKLG-20261002-u1rc (EPIC-20261001-ul4p). Every environment name is LISKOV_*, with no alias and no fallback, and only credentials are secrets. - acurast-app.yml takes the IPFS endpoint as the new `ipfs-endpoint` input (empty = the default no-spend proxy) and declares exactly two secrets, LISKOV_CODE_ENCRYPTION_KEY and LISKOV_IPFS_API_KEY. - ipfs-pin reads its endpoint only from `ipfs-endpoint` and its key from LISKOV_IPFS_API_KEY; artifact-pin-attest reads LISKOV_ARTIFACT_PIN_URL behind `pin-url`. dist/ rebuilt for both. - Removing the old secrets is a breaking change to the reusable workflow's secret contract, so every internal action reference moves to @v2 and the README documents v2.0.0; v1 stays frozen at v1.3.2. - New guard actions/shared/legacy-env-names.test.ts (retired-apex pattern), and workflow.test.ts pins the exact secret and pin-step env keys and the ipfs-endpoint wiring. The IPFS upload contract (shared resource 5) is unchanged; only client configuration names change. No tag is cut here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXUXjyYggDhZ5V4ew6iV6R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every environment name the reusable Acurast workflow and its actions read is now
LISKOV_*, with no alias and no fallback, and only credentials are secrets.acurast-app.ymltakes the IPFS endpoint as a newipfs-endpointinput (string, optional, default""= the default no-spend proxy) and declares exactly two secrets:LISKOV_CODE_ENCRYPTION_KEYandLISKOV_IPFS_API_KEY.ipfs-pinreads its endpoint only fromipfs-endpointand its key fromLISKOV_IPFS_API_KEY;artifact-pin-attestreadsLISKOV_ARTIFACT_PIN_URLbehindpin-url.dist/rebuilt for both; the dist diff is exactly the source change.@v2and the README documents v2.0.0; v1 stays frozen at v1.3.2. No tag is cut here.actions/shared/legacy-env-names.test.ts(retired-apex pattern) fails on any legacy name underactions/or.github/workflows/;workflow.test.tspins the exact secret keys, pin-step env keys and theipfs-endpointwiring.The IPFS upload contract (shared resource 5) is unchanged; only client configuration names change. No caller repository is edited here.
Validation on tree
8a12a4e0a376cfb636c7ad99d97fac1ccc8afa8a(commit78d4d62), run by the independent reviewer:pnpm install --frozen-lockfile,pnpm typecheck,pnpm test(42/42 node tests, both python suites),python3 -m compileall, andpnpm check:dist(no drift) all pass; the item's validation greps are empty.Refs BKLG-20261002-u1rc, EPIC-20261001-ul4p.
🤖 Generated with Claude Code
https://claude.ai/code/session_014itmcni3BQd7JazNL7NQrq