Refactor comment skipping logic into reusable method - #296
Merged
Merged
Conversation
skip_whitespace_in_range skipped comments without invoking on_comment, so 'color: /* c */ green' lost its comment. Regression from #279.
Contributor
🎉 Package Size Decrease
|
Member
Author
|
The Generated by Claude Code |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the comment-skipping logic in the lexer into a dedicated
_skip_comment()method to improve code maintainability and reduce duplication.Key Changes
_skip_comment()method in theLexerclassvifrom vitest for mockingImplementation Details
_skip_comment()method encapsulates the logic for advancing past/*and*/delimiters and handling the content in betweenon_commentcallback to be properly invoked during comment processinghttps://claude.ai/code/session_019FWMrZqm4cPwisLctbdiN1