Skip to content

bump Go toolchain for CVE-2026-111943 - #1021

Merged
Mzack9999 merged 1 commit into
devfrom
fix/go-toolchain-cve
Oct 23, 2026
Merged

Mzack9999 merged 1 commit into
devfrom
fix/go-toolchain-cve

Conversation

@dogancanbakir

@dogancanbakir dogancanbakir commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Fixes #1020

Requires go 1.26.10 in go.mod (go install ignores toolchain) so builds include the CVE-2026-111943 fix (golang/go#82345).

Summary by CodeRabbit

  • New Features
    • Added an option to configure TLS key-exchange groups in ctls scan mode. Results report the configured groups.
  • Bug Fixes
    • Improved TLS 1.3 version reporting and handshake handling.
    • TLS key-exchange group settings are rejected for unsupported scan modes.
  • Changes
    • Removed NPN from JA3/JA3S fingerprints and no longer recognize several legacy cipher-suite names.
  • Chores
    • Updated the Go toolchain requirement and dependency versions.
  • Documentation
    • Updated installation and development documentation for Go 1.26.10.

@dogancanbakir dogancanbakir self-assigned this Oct 20, 2026
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 07b40dd6-1b92-4339-bd92-c90ab0f0a77e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: a928b75d-f320-4dfd-9605-2634c788f6b0
📥 Commits

Reviewing files that changed from the base of the PR and between 83cd7fb and 805e049.

📒 Files selected for processing: 3
  • CLAUDE.md
  • README.md
  • go.mod

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The module adds a Go toolchain declaration for go1.26.10. It retains the go1.25.0 language version.

Changes

Go toolchain update

Layer / File(s) Summary
Toolchain declaration
go.mod
The module declares toolchain version go1.26.10 and retains language version go1.25.0.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: High

Merge Risk: ⚪ Minimal · up to 805e0

This change moves the Go requirement to a version that includes the crypto/x509 security fix. The release workflows read the version from go.mod, so release builds will use that patched toolchain. No merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: updating the Go toolchain to address CVE-2026-111943.
Linked Issues check Passed Issue #1020 requires release builds to use a patched Go version for CVE-2026-111943. go.mod now declares go 1.26.10, which is a patched version named by the issue. The change also updates the docu…
Out of Scope Changes check Passed The changes update go.mod and align the Go version in CLAUDE.md and README.md. These changes directly support issue #1020. No unrelated production, dependency, or configuration changes are evide…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue #1020 requires release builds to use a patched Go version for CVE-2026-111943. go.mod now declares go 1.26.10, which is a patched version named by the issue. The change also updates the documented minimum Go version. No additional coding or automated-test requirement is stated.

Full details: Out of Scope Changes check

Explanation

The changes update go.mod and align the Go version in CLAUDE.md and README.md. These changes directly support issue #1020. No unrelated production, dependency, or configuration changes are evidenced.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the Go version line
And finds a newer toolchain in place
The language version stays as before
The rabbit hops through fields of clover
And leaves a neat pawprint by the file

Comment @coderabbitai help to get the list of available commands.

@dogancanbakir
dogancanbakir changed the base branch from main to dev October 22, 2026 05:27
@dogancanbakir dogancanbakir reopened this Oct 22, 2026
@Mzack9999
Mzack9999 merged commit faba9a1 into dev Oct 23, 2026
14 checks passed
@Mzack9999
Mzack9999 deleted the fix/go-toolchain-cve branch October 23, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bump Go toolchain for CVE-2026-111943

2 participants