Skip to content

test(losses): pin LossInputs occupancy, tiling and occupancy-range checks - #615

Open
k-chrispens wants to merge 1 commit into
mainfrom
badtest/20261105-2205-modal
Open

k-chrispens wants to merge 1 commit into
mainfrom
badtest/20261105-2205-modal

Conversation

@k-chrispens

@k-chrispens k-chrispens commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Expanded validation coverage for missing-atom coordinates and B-factors, invalid occupancies, and consistency of atom data across ensemble and particle batch shapes.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The loss input tests now check missing-atom cleanup, reject occupancies outside the valid range, and verify tensor values across ensemble and particle batch shapes.

Changes: Loss input tests

Layer / File(s) Summary
Loss input behavior
tests/losses/test_loss_inputs.py
Tests check mean-coordinate replacement for missing atoms, missing and preserved B-factors, rejection of invalid occupancies, and tensor values across batch shapes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: marcuscollins

Merge Risk: Minimal · up to 8aef4

This change only adds tests for loss input cleaning, occupancy validation and batched tensor values, so it does not change runtime behavior. No concrete defect remains. The failing secret-scan checks come from a GitHub App credential error in CI configuration and are unrelated to the code in this PR.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "test(losses): pin LossInputs occupancy, tiling and occupancy-range checks" matches the changeset. The raw summary says the tests verify occupancy-range rejection (below 0 or above 1), unifo…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "test(losses): pin LossInputs occupancy, tiling and occupancy-range checks" matches the changeset. The raw summary says the tests verify occupancy-range rejection (below 0 or above 1), uniform per-ensemble occupancies, and tiled coordinates across ensemble and particle batch shapes, all in tests/losses/test_loss_inputs.py. The title also names the test scope the PR objectives describe. The title omits the mean-coordinate and B-factor checks, which is acceptable because the title need not cover every detail.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9f647211-4c6a-4f48-8e91-12740631d6db
Commits

Reviewing files that changed from the base of the PR and between cc7d395 and 8aef49b.

Files selected for processing: 1

  • tests/losses/test_loss_inputs.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@k-chrispens
k-chrispens marked this pull request as ready for review November 16, 2026 01:04
@k-chrispens
k-chrispens requested a review from a team as a code owner November 16, 2026 01:04
Copilot AI balanced review requested due to automatic review settings November 16, 2026 01:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

This branch is waiting to be deployed

1 waiting deployment
gpu-testing — 8aef49ba Waiting Nov 16, 2026 by k-chrispens via protenix-dev #1210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants