You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(frame-transforms): check rigid align on 3D clouds and masks - #516
Makes it so we test on some actual point clouds, rather than on a line of coordinates like the original tests I wrote. Also moves the try except to pytest.importorskip
Summary by CodeRabbit
Tests
Expanded coverage for rigid-motion alignment using varied point clouds in both PyTorch and JAX.
Added checks for recovered coordinates, inverse transforms, and the exclusion of corrupted reference points through zero masks or weights.
Updated Boltz consistency checks to skip when the implementation is unavailable.
The reason will be displayed to describe this comment to others. Learn more.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Review was skipped as selected files did not have any reviewable changes.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: cca8baad-c814-47a5-9358-9aaf25c77cc3
Commits
Reviewing files that changed from the base of the PR and between 6ba12ef and b8f4270.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The frame-transform tests now use seeded full-rank point clouds to check known rigid motions in PyTorch and JAX. They also test mask and weight exclusions and update how the Boltz alignment implementation is accessed.
Changes: Frame Alignment Tests
Layer / File(s)
Summary
Known rigid-motion checks tests/utils/test_frame_transforms.py
A seeded fixture creates full-rank point clouds with known rotations and translations. PyTorch and JAX tests check aligned coordinates, inverse transforms, and transform application.
Exclusion and Boltz consistency checks tests/utils/test_frame_transforms.py
PyTorch and JAX tests check that masks or weights exclude corrupted reference points. The Boltz test accesses the implementation through its module, and NumPy uses the module-level import.
No concrete issue remains that should delay merging these alignment tests.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: testing rigid alignment on 3D point clouds and masks.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 6 functions across 1 files.
Finishing Touches
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 8979d851-1e27-4269-bba3-4576fc7a5c06
Commits
Reviewing files that changed from the base of the PR and between 4cfe45d and 7f46d83.
Files selected for processing: 1
tests/utils/test_frame_transforms.py
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
k-chrispens
changed the title
test(frame-transforms): check rigid align on 3D clouds, mirrors and masks
test(frame-transforms): check rigid align on 3D clouds and masks
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it so we test on some actual point clouds, rather than on a line of coordinates like the original tests I wrote. Also moves the try except to pytest.importorskip
Summary by CodeRabbit