Skip to content

test(frame-transforms): check rigid align on 3D clouds and masks - #516

Open
k-chrispens wants to merge 2 commits into
mainfrom
badtest/20261015-1444-modal
Open

k-chrispens wants to merge 2 commits into
mainfrom
badtest/20261015-1444-modal

Conversation

@k-chrispens

@k-chrispens k-chrispens commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Makes it so we test on some actual point clouds, rather than on a line of coordinates like the original tests I wrote. Also moves the try except to pytest.importorskip

Summary by CodeRabbit

  • Tests
    • Expanded coverage for rigid-motion alignment using varied point clouds in both PyTorch and JAX.
    • Added checks for recovered coordinates, inverse transforms, and the exclusion of corrupted reference points through zero masks or weights.
    • Updated Boltz consistency checks to skip when the implementation is unavailable.

@k-chrispens
k-chrispens requested a review from a team as a code owner October 24, 2026 00:12
Copilot AI balanced review requested due to automatic review settings October 24, 2026 00:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cca8baad-c814-47a5-9358-9aaf25c77cc3
Commits

Reviewing files that changed from the base of the PR and between 6ba12ef and b8f4270.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The frame-transform tests now use seeded full-rank point clouds to check known rigid motions in PyTorch and JAX. They also test mask and weight exclusions and update how the Boltz alignment implementation is accessed.

Changes: Frame Alignment Tests

Layer / File(s) Summary
Known rigid-motion checks
tests/utils/test_frame_transforms.py
A seeded fixture creates full-rank point clouds with known rotations and translations. PyTorch and JAX tests check aligned coordinates, inverse transforms, and transform application.
Exclusion and Boltz consistency checks
tests/utils/test_frame_transforms.py
PyTorch and JAX tests check that masks or weights exclude corrupted reference points. The Boltz test accesses the implementation through its module, and NumPy uses the module-level import.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: Minimal · previous review 7f46d

No concrete issue remains that should delay merging these alignment tests.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: testing rigid alignment on 3D point clouds and masks.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 6 functions across 1 files.

Finishing Touches

🧪 Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8979d851-1e27-4269-bba3-4576fc7a5c06
Commits

Reviewing files that changed from the base of the PR and between 4cfe45d and 7f46d83.

Files selected for processing: 1

  • tests/utils/test_frame_transforms.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@marcuscollins marcuscollins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Comment thread tests/utils/test_frame_transforms.py Resolved
Comment thread tests/utils/test_frame_transforms.py Resolved
Comment thread tests/utils/test_frame_transforms.py Resolved
Comment thread tests/utils/test_frame_transforms.py Resolved
Comment thread tests/utils/test_frame_transforms.py Resolved
@k-chrispens
k-chrispens force-pushed the badtest/20261015-1444-modal branch from 97c1fd3 to 28b0106 Compare October 27, 2026 18:41
@k-chrispens k-chrispens changed the title test(frame-transforms): check rigid align on 3D clouds, mirrors and masks test(frame-transforms): check rigid align on 3D clouds and masks Oct 27, 2026
@k-chrispens
k-chrispens force-pushed the badtest/20261015-1444-modal branch from 28b0106 to 6930574 Compare October 27, 2026 19:06
@k-chrispens
k-chrispens force-pushed the badtest/20261015-1444-modal branch from 6930574 to 7f46d83 Compare October 27, 2026 21:47
@k-chrispens
k-chrispens force-pushed the badtest/20261015-1444-modal branch from 7f46d83 to b2d746a Compare October 28, 2026 02:36
@k-chrispens
k-chrispens force-pushed the badtest/20261015-1444-modal branch from b2d746a to 382ffb6 Compare November 4, 2026 00:48
@k-chrispens
k-chrispens force-pushed the badtest/20261015-1444-modal branch from 382ffb6 to 54680cb Compare November 4, 2026 23:17
@k-chrispens
k-chrispens force-pushed the badtest/20261015-1444-modal branch from 54680cb to 6ba12ef Compare November 6, 2026 07:34
@k-chrispens
k-chrispens force-pushed the badtest/20261015-1444-modal branch from 6ba12ef to 12bda93 Compare November 9, 2026 22:53

This branch is waiting to be deployed

1 waiting deployment
gpu-testing — b8f42705 Waiting Nov 16, 2026 by k-chrispens via protenix-dev #1207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants