Repository navigation
fix(tool): honor shouldRegister on Laravel MCP tools - #1048
Open
nbullorini wants to merge 1 commit into
Open
nbullorini wants to merge 1 commit into
nbullorini wants to merge 1 commit into
Conversation
Laravel MCP tools can define shouldRegister() to conditionally register themselves. Prism wrapped them via Tool::make() and always sent them to the provider. Ineligible LaravelMcpTool instances are now filtered in withTools(), so they are neither sent to the provider nor callable. Fixes prism-php#979 Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
wishborn
added a commit
to Particle-Academy/prism
that referenced
this pull request
Oct 27, 2026
…-should-register fix(tool): honor shouldRegister on Laravel MCP tools (upstream prism-php#1048)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Laravel MCP tools can define
shouldRegister()to conditionally register themselves (e.g. only for authenticated users). Prism wrapped them viaTool::make()but always sent them to the provider, so tools that should be hidden were still exposed and callable.Ineligible
LaravelMcpToolinstances are now filtered inwithTools(), using laravel/mcp's owneligibleForRegistration(), so they are neither sent to the provider nor callable.Fixes #979
Changes
LaravelMcpTool::eligibleForRegistration(), delegating to the wrapped MCP toolHasTools::withTools()shouldRegister(Request $request)shouldRegistersupport in the tools docs