Add workflow_call trigger to build workflow - #839
Conversation
a345698 to
0171fea
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The added github.event_name == 'workflow_call' condition never evaluates true in a reusable workflow, so the change does not reliably run the build when called as intended.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
This PR adds a workflow_call trigger to .github/workflows/build.yml so that the SPEL build workflow can be invoked as a reusable workflow from other repositories (e.g. amigen9). It declares a workflow_call.inputs block that reuses the SPEL build parameters and extends the trigger job's if condition to include workflow_call. This is described as Phase A of enabling amigen9 to run ephemeral CI builds against this workflow.
Changes:
- Add a
workflow_calltrigger with aninputsblock covering a subset of the existingworkflow_dispatchinputs. - Add
github.event_name == 'workflow_call'to thetriggerjob'sifgate.
| File | Description |
|---|---|
| .github/workflows/build.yml | Adds workflow_call trigger inputs and extends the trigger job's if condition to attempt to run for reusable-workflow invocations |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Adds a workflow_call trigger to build.yml, mirroring the existing workflow_dispatch inputs, so other repos (e.g. amigen9) can invoke this build workflow as a reusable workflow.
0171fea to
784c220
Compare
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Exposing the build workflow as a cross-repo reusable workflow whose gating depends on caller-controlled event context carries security and operational implications that warrant human review.
Review effort: Balanced
Findings: 1
Open (1)
Resolved since last review (2)
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
plus3it/spel#839 (feat/workflow-call-support) has merged into master at 525049d. Point the build job there instead of the PR branch tip.


Changes offered/proposed in this pull request:
workflow_calltrigger tobuild.yml, mirroring the existingworkflow_dispatchinputs, so other repos (e.g. amigen9) can invoke this build workflow as a reusable workflow.This is Phase A of enabling amigen9 to run ephemeral CI builds by calling into this workflow. No other jobs change: the
triggerjob's "Set spel inputs" step already reads${{ inputs.* }}generically regardless of trigger type, and therelease-prjob stays gated onscheduleorinputs.SPEL_RELEASE.