Skip to content

Add workflow_call trigger to build workflow - #839

Merged
lorengordon merged 1 commit into
plus3it:masterfrom
lorengordon:feat/workflow-call-support
Sep 24, 2026
Merged

lorengordon merged 1 commit into
plus3it:masterfrom
lorengordon:feat/workflow-call-support

Conversation

@lorengordon

@lorengordon lorengordon commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Changes offered/proposed in this pull request:

  • Add a workflow_call trigger to build.yml, mirroring the existing workflow_dispatch inputs, so other repos (e.g. amigen9) can invoke this build workflow as a reusable workflow.

This is Phase A of enabling amigen9 to run ephemeral CI builds by calling into this workflow. No other jobs change: the trigger job's "Set spel inputs" step already reads ${{ inputs.* }} generically regardless of trigger type, and the release-pr job stays gated on schedule or inputs.SPEL_RELEASE.

@lorengordon
lorengordon force-pushed the feat/workflow-call-support branch from a345698 to 0171fea Compare September 23, 2026 19:19

@lorengordon lorengordon left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/build

@lorengordon
lorengordon requested review from a team and a balanced review from Copilot September 24, 2026 13:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The added github.event_name == 'workflow_call' condition never evaluates true in a reusable workflow, so the change does not reliably run the build when called as intended.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 High severity · 1 Low severity

Open (2)
What changed in this PR

This PR adds a workflow_call trigger to .github/workflows/build.yml so that the SPEL build workflow can be invoked as a reusable workflow from other repositories (e.g. amigen9). It declares a workflow_call.inputs block that reuses the SPEL build parameters and extends the trigger job's if condition to include workflow_call. This is described as Phase A of enabling amigen9 to run ephemeral CI builds against this workflow.

Changes:

  • Add a workflow_call trigger with an inputs block covering a subset of the existing workflow_dispatch inputs.
  • Add github.event_name == 'workflow_call' to the trigger job's if gate.
File Description
.github/​workflows/​build.yml Adds workflow_call trigger inputs and extends the trigger job's if condition to attempt to run for reusable-workflow invocations

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated
Adds a workflow_call trigger to build.yml, mirroring the existing
workflow_dispatch inputs, so other repos (e.g. amigen9) can invoke
this build workflow as a reusable workflow.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Exposing the build workflow as a cross-repo reusable workflow whose gating depends on caller-controlled event context carries security and operational implications that warrant human review.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (2)

Comment thread .github/workflows/build.yml
Comment thread .github/workflows/build.yml
Comment thread .github/workflows/build.yml
@mergify

mergify Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@lorengordon
lorengordon merged commit 525049d into plus3it:master Sep 24, 2026
28 checks passed
@lorengordon
lorengordon deleted the feat/workflow-call-support branch September 24, 2026 18:22
lorengordon added a commit to plus3it/amigen9 that referenced this pull request Sep 24, 2026
plus3it/spel#839 (feat/workflow-call-support) has merged into master at
525049d. Point the build job there instead of the PR branch tip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants