Fix/table and ldap question empty selection sentinel - #53
Merged
Lainow merged 2 commits intoSep 1, 2026
Conversation
Lainow
approved these changes
Sep 1, 2026
Lainow
deleted the
fix/table-and-ldap-question-empty-selection-sentinel
branch
September 1, 2026 08:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
LdapQuestionandTableQuestion's Actor/Item(Dropdown) columns are rendered with GLPI's shared ajax dropdown widget, which always exposes a "-----" (empty) choice whose id is0. Neither question type filtered that sentinel the way core'sAbstractQuestionTypeActorsalready does for its own dropdown, so selecting the empty choice or clearing a previous selection saved and displayed a literal"0"instead of an empty answer.Changes
LdapQuestion::prepareEndUserAnswer(): treat"0"as no answer.TableQuestion: newnormalizeDropdownCells()helper, applied in bothprepareEndUserAnswer()andvalidateAnswer(), treats"0"as empty for Actor/Item(Dropdown) columns only (other column types, e.g. Number, keep0as a valid value).Screenshots
Before :

After :
