Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building
ExecutedQuery.typescurrently spreads the accumulated object once per field. With many distinct column names, this makes metadata construction quadratic, even when the query returns no rows.Use
Object.fromEntriesto construct the map in linear time. Add compatibility coverage for wide empty results, duplicate names, special names such as__proto__, andNULLtype defaults.A local benchmark of
Connection.execute, using mocked HTTP responses with unique column names and zero rows, produced these median timings on Node 22.22.2 / arm64:Each measurement uses nine runs after three warmups and includes response JSON parsing. These are synthetic client-side measurements, not database latency measurements.
Validation:
npm test: all 44 tests pass on Node 22.22.2 and 24.19.0, including the ESM and CommonJS TypeScript builds.npm run lint: passes.A matching 1.x backport based on v1.20.2 is also prepared. There is currently no upstream 1.x maintenance branch to target with a separate backport PR.