Skip to content

Add keyspace parameters commands - #1458

Merged
no-itsbackpack merged 2 commits into
mainfrom
egomez/keyspace-parameters
Oct 2, 2026
Merged

no-itsbackpack merged 2 commits into
mainfrom
egomez/keyspace-parameters

Conversation

@no-itsbackpack

@no-itsbackpack no-itsbackpack commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Adds pscale keyspace parameters for viewing and changing the VTTablet and MySQL parameters of a Vitess keyspace from the CLI, the same parameters available on a keyspace's VTTablets and MySQL tabs on the Clusters page.

  • parameters list (or bare parameters) shows each parameter with its current value, default, and whether it's overridden. --namespace narrows it to vttablet or mysqld, like pscale branch parameters --namespace for Postgres.
  • parameters set changes parameters with repeatable --parameters namespace.name=value, the same format as pscale branch resize --parameters, and resets them to their defaults with --reset namespace.name. Changes for both namespaces are submitted together and roll out to the keyspace.
  • parameters changes list, show, and cancel follow a change's rollout or cancel one that hasn't finished.
pscale keyspace parameters set commerce main commerce --org acme \
  --parameters vttablet.vreplication-parallel-insert-workers=4 \
  --parameters vttablet.vreplication_max_time_to_retry_on_error=720h

The agent guide (AGENTS.md) documents the new commands.

🤖 Generated with Claude Code

Add `pscale keyspace parameters` to list a keyspace's VTTablet and MySQL
parameters, change or reset them with `parameters set`, and follow or
cancel the resulting changes with `parameters changes`.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@no-itsbackpack
no-itsbackpack marked this pull request as ready for review October 2, 2026 21:24
@no-itsbackpack
no-itsbackpack requested a review from a team as a code owner October 2, 2026 21:24
Match `pscale branch parameters` by calling vttablet and mysqld
namespaces, both for the `--namespace` filter and the
`--parameters namespace.name=value` flag. Change summaries now list only
the parameters whose values change.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Left a non-blocking comment because Cursor Bugbot was still pending after the 8-minute wait, so this run did not approve. Human review is needed and no reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: cli-reviewer

@no-itsbackpack
no-itsbackpack merged commit f7a6c0a into main Oct 2, 2026
4 checks passed
@no-itsbackpack
no-itsbackpack deleted the egomez/keyspace-parameters branch October 2, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants