Rename read-only replica commands to dedicated read replica commands - #1457
Merged
Merged
Conversation
Co-authored-by: Nick Holden <nick.r.holden@gmail.com>
Co-authored-by: Nick Holden <nick.r.holden@gmail.com>
Co-authored-by: Nick Holden <nick.r.holden@gmail.com>
Co-authored-by: Nick Holden <nick.r.holden@gmail.com>
cursor
Bot
changed the title
nholden
marked this pull request as ready for review
October 2, 2026 20:34
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dgraham
approved these changes
Oct 2, 2026
Cobra only prints a command's Deprecated message when that command itself runs, so `pscale read-only-replica list` and the other subcommands were silent. Wire cmdutil.WarnDeprecated into the alias's PersistentPreRunE, matching the deprecated workflow command, so every subcommand warns on stderr while stdout stays unchanged. Also use the new "dedicated read replica deleted" result string in the delete command's JSON output. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customers can manage Postgres replicas with
pscale dedicated-read-replicaand connect roles with--dedicated-read-replica. The CLI keeps the previous command and flag as deprecated aliases so existing scripts continue to work.