Repository navigation
Fix Silo deposited USD values to use current token prices - #428
Merged
Merged
Conversation
✅ Deploy Preview for pintomoney ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Silo's “Total Value Deposited” used recorded PDV multiplied by the current Pinto price, which can substantially understate the current value of deposited LP tokens. For example, the PINTO/cbETH deposits at Base block 53298716 displayed about $10,208 despite representing about $39,028 of pool assets.
Use deposited token amounts, including germinating deposits, multiplied by the current USD token price (
lpUsdfor LP tokens and the Pinto price for PINTO). Apply the same calculation to the Silo table and individual token page. Recorded PDV and reward calculations remain unchanged; unavailable valuation data displays a dash.Pool liquidity can still exceed deposited value when LP tokens are held outside the Silo, and the contract's LP unit-price precision can introduce small rounding differences.
Validation: