Remove the thread metric tag - #148
Merged
vahidhashemian merged 1 commit intoSep 17, 2026
Merged
Conversation
jeffxiang
approved these changes
Sep 17, 2026
vahidhashemian
added a commit
that referenced
this pull request
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
threadtag on PSC OpenTSDB metrics did not provide a useful aggregation or debugging dimension, and it multiplied time series by JVM thread, putting unnecessary load on the metrics backend.OpenTSDBReporterno longer attachesthreadto published points.Counters, meters, gauges, histograms, and timers are written with the remaining tags only: URI, hostname, IP, locality, instance type, process, project, version, and any additional client tags.
PSC still records thread id on
PscMetricTagand still uses it when creating metric tag keys and registries. Client APIs, registry identity, reporter scheduling, and non-OpenTSDB reporters are unchanged.Scope of impact
threadwill no longer see that tag. Series that previously differed only bythreadnow share one tag set, which is the intended cardinality reduction.thread, concurrent reporters for the same metric name and remaining tags can write to the same OpenTSDB series at the same timestamp. Per-thread counter values overwrite each other instead of appearing as separate series.thread.PscMetricTag.getThreadId()remains available.