Repository navigation
Conversation
Adds the go-around/approach consensus and nearby-lookup keys the client validates, and the general-aviation class selector.
The full threshold set now lives in the client. settings.json carries only the class overrides, grouped by flight phase (version 2), from .json or .jsonc sources. Adds the airline settings/thresholds.jsonc template to the zip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vmsacars PR vmslabs/acars#313 adds threshold keys that the schema's
partialValuesrejects, because it setsadditionalProperties: false. Asettings.jsonthat overrides any of them would fail the build.Adds 11 keys, all optional. Their defaults stay in the client's
FlightThresholdsrecord, so none of them are inrequired:goAroundClimbSeconds,goAroundSustainSec,goAroundFieldCeilingFt,goAroundMinGainFt,goAroundN1RisePct,goAroundThrottleRisePct,goAroundThrustBaselineSecondsapproachDescentFpmnearbyLookupCeilingAglFt,nearbyLookupDescentCeilingAglFt,nearbyLookupRangeNmEach key's type, minimum and maximum match the client's
Keystable. The overrideclassselector now also acceptsgeneral-aviation.