Skip to content

feat(settings): accept the phase-consensus threshold keys - #37

Open
nabeelio wants to merge 7 commits into
mainfrom
feat/thresholds-phase-consensus-keys
Open

nabeelio wants to merge 7 commits into
mainfrom
feat/thresholds-phase-consensus-keys

Conversation

@nabeelio

Copy link
Copy Markdown
Member

vmsacars PR vmslabs/acars#313 adds threshold keys that the schema's partialValues rejects, because it sets additionalProperties: false. A settings.json that overrides any of them would fail the build.

Adds 11 keys, all optional. Their defaults stay in the client's FlightThresholds record, so none of them are in required:

  • go-around consensus: goAroundClimbSeconds, goAroundSustainSec, goAroundFieldCeilingFt, goAroundMinGainFt, goAroundN1RisePct, goAroundThrottleRisePct, goAroundThrustBaselineSeconds
  • approach: approachDescentFpm
  • airborne airport lookup: nearbyLookupCeilingAglFt, nearbyLookupDescentCeilingAglFt, nearbyLookupRangeNm

Each key's type, minimum and maximum match the client's Keys table. The override class selector now also accepts general-aviation.

Adds the go-around/approach consensus and nearby-lookup keys the client validates, and the general-aviation class selector.
The full threshold set now lives in the client. settings.json carries
only the class overrides, grouped by flight phase (version 2), from
.json or .jsonc sources. Adds the airline settings/thresholds.jsonc
template to the zip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant