Skip to content

added error on translation fail - #57

Merged
williamdes merged 2 commits into
phpmyadmin:masterfrom
br4nnigan:master
Oct 23, 2026
Merged

williamdes merged 2 commits into
phpmyadmin:masterfrom
br4nnigan:master

Conversation

@br4nnigan

Copy link
Copy Markdown

would be helpful to have

@williamdes

Copy link
Copy Markdown
Member

Sure, could you fix the lint test ?
See: https://github.com/phpmyadmin/motranslator/actions/runs/16139901026/job/46342267185?pr=57#step:6:28

Also, please add a unit test for this new case

@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.38%. Comparing base (03b6330) to head (cae0ec2).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
+ Coverage     94.29%   94.38%   +0.09%     
- Complexity      108      109       +1     
============================================
  Files             8        8              
  Lines           298      303       +5     
============================================
+ Hits            281      286       +5     
  Misses           17       17              
Flag Coverage Δ
unit-8.2 98.96% <100.00%> (+0.01%) ⬆️
unit-8.3 98.96% <100.00%> (+0.01%) ⬆️
unit-8.4 94.38% <100.00%> (+0.09%) ⬆️
unit-8.5 94.38% <100.00%> (+0.09%) ⬆️
unit-8.6 94.38% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

br4nnigan and others added 2 commits October 23, 2026 13:47
Apply the phpcs fixes for the new error handling in gettext() and
ngettext(), document the $error property as no longer parse-only and
cover the new ERROR_KEY_DOES_NOT_EXIST cases.

Co-Authored-By: DeepSeek <noreply@deepseek.com>
@williamdes williamdes self-assigned this Oct 23, 2026
@williamdes williamdes added this to the 6.0.2 milestone Oct 23, 2026
@williamdes
williamdes merged commit 2cdcfc3 into phpmyadmin:master Oct 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants