Repository navigation
added error on translation fail - #57
Merged
Merged
Conversation
Member
|
Sure, could you fix the lint test ? Also, please add a unit test for this new case |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
============================================
+ Coverage 94.29% 94.38% +0.09%
- Complexity 108 109 +1
============================================
Files 8 8
Lines 298 303 +5
============================================
+ Hits 281 286 +5
Misses 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Apply the phpcs fixes for the new error handling in gettext() and ngettext(), document the $error property as no longer parse-only and cover the new ERROR_KEY_DOES_NOT_EXIST cases. Co-Authored-By: DeepSeek <noreply@deepseek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
would be helpful to have