ext/standard: Make str_ends_with frameless - #23510
Merged
Merged
Conversation
devnexen
approved these changes
Aug 29, 2026
mvorisek
reviewed
Aug 30, 2026
| /** @compile-time-eval */ | ||
| /** | ||
| * @compile-time-eval | ||
| * @frameless-function {"arity": 2} |
Contributor
There was a problem hiding this comment.
Any reason why not all "compile-time-eval" functions are not frameless?
Member
Author
There was a problem hiding this comment.
Yeah Perhaps a good idea for me to look into later. At least some of them should be frameless. e.g. ltrim rtrim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
str_starts_withis frameless,str_ends_withalso should be frameless.