Skip to content

WIP/POC - Add database migrations capability using Phinx. - #958

Closed
noplanman wants to merge 1 commit into
php-telegram-bot:devfrom
noplanman:phinx_db_migrations
Closed

noplanman wants to merge 1 commit into
php-telegram-bot:devfrom
noplanman:phinx_db_migrations

Conversation

@noplanman

Copy link
Copy Markdown
Member

Proof of concept to allow easy database migrations using Phinx.

Before anything like this gets merged into core, we really should think about a centralised config management, like using phpdotenv or just a simple config.php that contains all configurations and credentials.

Probably makes sense to merge the Manager into core!

@akalongman In the scheme of things, I look forward to see how the migrations could work with Laravels DB library, which would also allow the whole DB management to become muuuch cleaner and easier.

@VoDmAl VoDmAl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this POC

@akalongman

Copy link
Copy Markdown
Member

@noplanman please take a look #963

@asafov

asafov commented May 26, 2020

Copy link
Copy Markdown

I can help with write migration files for phinx.

@noplanman

Copy link
Copy Markdown
Member Author

Thanks @asafov, this PR is a proof of concept and for sure the DB structure needs to be "clean" and nice before putting any more work into this 👍

@akalongman

Copy link
Copy Markdown
Member

Closing this proof of concept. The project settled on plain SQL migration files under utils/db-schema-update/, which CI now runs on MariaDB and MySQL and compares against structure.sql (#1505). Thanks for the groundwork.

@akalongman akalongman closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants